Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14993 )
Change subject: [docker] Adjust entrypoint variable to be more composable ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/14993/2/docker/kudu-entrypoint.sh File docker/kudu-entrypoint.sh: http://gerrit.cloudera.org:8080/#/c/14993/2/docker/kudu-entrypoint.sh@60 PS2, Line 60: --use_hybrid_clock=false" > Unrelated to this change, but could this be updated now to use the built-in If using the built-in NTP client, a proper NTP server is needed anyway, that means the container either should be able to access the Internet to use the hard-coded set of NTP servers for the built-in client or point it to some other NTP server. I think a good alternative is to keep the default setting for --use_hybrid_clock (which is 'true') and simply use the 'system_unsync' time source: --time_source=system_unsync I think it makes sense because dockerized Kudu most likely is used for test/toy purposes, where all containers are run at the same machine. -- To view, visit http://gerrit.cloudera.org:8080/14993 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic3451b3bb2d398f8e0bdea881103b6d4a74cb753 Gerrit-Change-Number: 14993 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 14 Jan 2020 19:31:57 +0000 Gerrit-HasComments: Yes
