Adar Dembo has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14995 )

Change subject: [build] Fix IWYU dependencies
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/14995/1/CMakeLists.txt
File CMakeLists.txt:

PS1:
I think gen_version_info should be a dependency of generated-headers rather 
than of iwyu, iwyu-fix, and tidy. It is a "generated header" after all.



--
To view, visit http://gerrit.cloudera.org:8080/14995
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2521a1d54b695971afbe445729e746beeb5db595
Gerrit-Change-Number: 14995
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 09 Jan 2020 18:30:52 +0000
Gerrit-HasComments: Yes

Reply via email to