Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14995 )
Change subject: [build] Fix IWYU dependencies ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/14995/1/CMakeLists.txt File CMakeLists.txt: PS1: > IWYU works for me without this fix. Just re-checked with changes in master-test.cc and found it indeed breaks. +1 to Adar's suggestion: it's better to put the gen_version_info into the generated-headers target. Thanks for the fix! -- To view, visit http://gerrit.cloudera.org:8080/14995 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2521a1d54b695971afbe445729e746beeb5db595 Gerrit-Change-Number: 14995 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 09 Jan 2020 19:07:40 +0000 Gerrit-HasComments: Yes
