Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14999 )
Change subject: [master] KUDU-3036 reject DDLs which would lead to DoS ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/14999/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14999/2//COMMIT_MSG@7 PS2, Line 7: reject > I'm hesitant to do the non-atomic approach because of the messy rollback co OK, that makes sense to me. Thank you for the feedback. BTW, the problem might surface more often with larger installations: a simple DDL that adds or renames one column in a table can cause the issue to trigger if the table accumulated many partitions over time, especially if they happen to partition on a string column. However, I agree that without proper automatic rollback providing a non-atomic DDL option might turn into a bigger disaster for a cluster if an update on the system tablet fails in the middle. We could allow the option only for CREATE TABLE (where it's easy to rollback everything by dropping a table), but most likely there would be a problem with UPDATE TABLE anyways if corresponding CREATE TABLE hit the limit on maximum RPC size. -- To view, visit http://gerrit.cloudera.org:8080/14999 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7c212b635313a0aec5d9ebf8329319bae47f2dd2 Gerrit-Change-Number: 14999 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 10 Jan 2020 20:00:57 +0000 Gerrit-HasComments: Yes
