Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14999 )
Change subject: [master] KUDU-3036 reject DDLs which would lead to DoS ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/14999/2/src/kudu/integration-tests/master-stress-test.cc File src/kudu/integration-tests/master-stress-test.cc: http://gerrit.cloudera.org:8080/#/c/14999/2/src/kudu/integration-tests/master-stress-test.cc@764 PS2, Line 764: wait(true) > This is the default and can be omitted. Done http://gerrit.cloudera.org:8080/#/c/14999/2/src/kudu/master/sys_catalog.cc File src/kudu/master/sys_catalog.cc: PS2: > The enum refactoring (ATOMIC/CHUNKED vs. a size) probably belongs in the pr Done http://gerrit.cloudera.org:8080/#/c/14999/2/src/kudu/master/sys_catalog.cc@476 PS2, Line 476: return Status::ConfigurationError( > We use InvalidArgument when we reject DDLs in CatalogManager due to guard r Done -- To view, visit http://gerrit.cloudera.org:8080/14999 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7c212b635313a0aec5d9ebf8329319bae47f2dd2 Gerrit-Change-Number: 14999 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Sat, 11 Jan 2020 03:38:25 +0000 Gerrit-HasComments: Yes
