Hello Alexey Serbin, Andrew Wong,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/15025
to review the following change.
Change subject: maintenance_manager-test: deflake TestPriorityOpLaunch
......................................................................
maintenance_manager-test: deflake TestPriorityOpLaunch
Sometimes, the test didn't get its desired op execution order because the MM
would execute an op before all of the ops were registered. That is, the ops
weren't registered atomically, and an "unlucky" overlap of FindBestOp and
one of the registration calls would lead to an errant op execution.
We can fix this by using FLAGS_enable_maintenance_manager to disable the MM
while we register ops.
Before the fix, I could reliably reproduce a failure within 1000 executions
of the test.
After, I couldn't reproduce it in 30000 executions.
Change-Id: I06f3fd8fa952ed74bfaf2ac3dd55cd289f4b878b
---
M src/kudu/util/maintenance_manager-test.cc
1 file changed, 36 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/25/15025/1
--
To view, visit http://gerrit.cloudera.org:8080/15025
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I06f3fd8fa952ed74bfaf2ac3dd55cd289f4b878b
Gerrit-Change-Number: 15025
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
