Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15025 )
Change subject: maintenance_manager-test: deflake TestPriorityOpLaunch ...................................................................... maintenance_manager-test: deflake TestPriorityOpLaunch Sometimes, the test didn't get its desired op execution order because the MM would execute an op before all of the ops were registered. That is, the ops weren't registered atomically, and an "unlucky" overlap of FindBestOp and one of the registration calls would lead to an errant op execution. We can fix this by using FLAGS_enable_maintenance_manager to disable the MM while we register ops. Before the fix, I could reliably reproduce a failure within 1000 executions of the test. After, I couldn't reproduce it in 30000 executions. Change-Id: I06f3fd8fa952ed74bfaf2ac3dd55cd289f4b878b Reviewed-on: http://gerrit.cloudera.org:8080/15025 Reviewed-by: Alexey Serbin <[email protected]> Reviewed-by: Andrew Wong <[email protected]> Tested-by: Andrew Wong <[email protected]> --- M src/kudu/util/maintenance_manager-test.cc 1 file changed, 46 insertions(+), 11 deletions(-) Approvals: Alexey Serbin: Looks good to me, but someone else must approve Andrew Wong: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/15025 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I06f3fd8fa952ed74bfaf2ac3dd55cd289f4b878b Gerrit-Change-Number: 15025 Gerrit-PatchSet: 3 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120)
