Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15011 )
Change subject: fs: move file cache to server ...................................................................... Patch Set 3: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/15011/3/src/kudu/fs/block_manager.cc File src/kudu/fs/block_manager.cc: http://gerrit.cloudera.org:8080/#/c/15011/3/src/kudu/fs/block_manager.cc@a56 PS3, Line 56: > Since this is considered a user-facing API, should we keep this around and Good point w.r.t. notifying users of this flag. I think it's enough to add a release note for the change given this flag was tagged as 'evolving': https://github.com/apache/kudu/blob/b6a298558ef1fc1218c16b68b3031b3646f7e6db/src/kudu/util/flag_tags.h#L27-L34 http://gerrit.cloudera.org:8080/#/c/15011/2/src/kudu/server/server_base.cc File src/kudu/server/server_base.cc: http://gerrit.cloudera.org:8080/#/c/15011/2/src/kudu/server/server_base.cc@227 PS2, Line 227: esolver_ca > Yes; here we're forbidding values less than -1 (like -2, -3, etc.). Indeed. It seems I managed to misread the comparison operator, but switching to unsigned value for the flag seems to be a good outcome :) -- To view, visit http://gerrit.cloudera.org:8080/15011 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ice92c3622c954b06b773c58d51f08082010d7de3 Gerrit-Change-Number: 15011 Gerrit-PatchSet: 3 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 13 Jan 2020 23:00:04 +0000 Gerrit-HasComments: Yes
