Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15011 )
Change subject: fs: move file cache to server ...................................................................... fs: move file cache to server To use the file cache in the WAL, it must be hoisted out from under the block manager into a more central location. I opted for ServerBase rather than FsManager given that some tests use multiple FsManagers. In an effort to avoid excessive plumbing in FsManager-using tests, I resuscitated the non-file-cache block manager code paths. It's not too much complexity and the PREDICT_TRUE macros should mitigate the cost of the branches somewhat. Both cached and non-cached code paths have test coverage: 1. Block manager tests explicitly instantiate a file cache. 2. All other non-server tests do not. 3. Server tests use the server's file cache. Change-Id: Ice92c3622c954b06b773c58d51f08082010d7de3 Reviewed-on: http://gerrit.cloudera.org:8080/15011 Reviewed-by: Andrew Wong <[email protected]> Tested-by: Kudu Jenkins Reviewed-by: Alexey Serbin <[email protected]> --- M src/kudu/fs/block_manager-stress-test.cc M src/kudu/fs/block_manager-test.cc M src/kudu/fs/block_manager.cc M src/kudu/fs/block_manager.h M src/kudu/fs/file_block_manager.cc M src/kudu/fs/file_block_manager.h M src/kudu/fs/fs_manager.cc M src/kudu/fs/fs_manager.h M src/kudu/fs/log_block_manager-test.cc M src/kudu/fs/log_block_manager.cc M src/kudu/fs/log_block_manager.h M src/kudu/server/server_base.cc M src/kudu/server/server_base.h 13 files changed, 230 insertions(+), 178 deletions(-) Approvals: Andrew Wong: Looks good to me, but someone else must approve Kudu Jenkins: Verified Alexey Serbin: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/15011 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ice92c3622c954b06b773c58d51f08082010d7de3 Gerrit-Change-Number: 15011 Gerrit-PatchSet: 4 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120)
