Hello Alexey Serbin, Kudu Jenkins, Andrew Wong,

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/15024

to look at the new patch set (#2).

Change subject: maintenance_manager-test: fix cascading CHECK failure
......................................................................

maintenance_manager-test: fix cascading CHECK failure

While trying to repro test flakiness, I saw that ASSERT_EVENTUALLY doesn't
handle --gtest_throw_on_failure correctly. And that also highlighted an
issue with the test where an ASSERT firing early could lead to a second
CHECK failure, obscuring the actual test failure.

Change-Id: I7a8ed5bedbcdb742bebe56327ffdbb885eef28b0
---
M src/kudu/util/maintenance_manager-test.cc
M src/kudu/util/test_util.cc
2 files changed, 22 insertions(+), 12 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/24/15024/2
--
To view, visit http://gerrit.cloudera.org:8080/15024
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7a8ed5bedbcdb742bebe56327ffdbb885eef28b0
Gerrit-Change-Number: 15024
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)

Reply via email to