Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15024 )
Change subject: maintenance_manager-test: fix cascading CHECK failure ...................................................................... maintenance_manager-test: fix cascading CHECK failure While trying to repro test flakiness, I saw that ASSERT_EVENTUALLY doesn't handle --gtest_throw_on_failure correctly. And that also highlighted an issue with the test where an ASSERT firing early could lead to a second CHECK failure, obscuring the actual test failure. Change-Id: I7a8ed5bedbcdb742bebe56327ffdbb885eef28b0 Reviewed-on: http://gerrit.cloudera.org:8080/15024 Reviewed-by: Alexey Serbin <[email protected]> Tested-by: Kudu Jenkins Reviewed-by: Andrew Wong <[email protected]> --- M src/kudu/util/maintenance_manager-test.cc M src/kudu/util/test_util.cc 2 files changed, 22 insertions(+), 12 deletions(-) Approvals: Alexey Serbin: Looks good to me, approved Kudu Jenkins: Verified Andrew Wong: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/15024 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I7a8ed5bedbcdb742bebe56327ffdbb885eef28b0 Gerrit-Change-Number: 15024 Gerrit-PatchSet: 3 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120)
