Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12517 )
Change subject: [tools] Support running the master and tablet server via the kudu binary ...................................................................... [tools] Support running the master and tablet server via the kudu binary Adds commands to the kudu tools to run the master and tablet server: - `kudu master run ...` - `kudu tserver run ...` This means we can ship a single binary in the kudu docker image or potentially the kudu-binary jar reducing the size by approximately 66%. Though follow up changes may be needed in the kudu-binary case. The behavior is the same as running the kudu-master and kudu-tserver binaries. The logging initialization was updated to ensure that the logging filenames are the same as when running via the dedicated binaries. A few logging fixes are included to ensure this capability is possible. This patch also contains a few related fixes for default flags ensuring that they can be overwritten when necessary. These changes also ensure flags are not incorrectly reported as non-default. Change-Id: I3717cbac930b3506a76f7a51388c64afbcbb480e Reviewed-on: http://gerrit.cloudera.org:8080/12517 Tested-by: Grant Henke <[email protected]> Reviewed-by: Adar Dembo <[email protected]> Reviewed-by: Andrew Wong <[email protected]> Reviewed-by: Alexey Serbin <[email protected]> --- M src/kudu/master/CMakeLists.txt M src/kudu/master/master-test.cc M src/kudu/master/master_main.cc A src/kudu/master/master_runner.cc A src/kudu/master/master_runner.h M src/kudu/server/diagnostics_log.cc M src/kudu/server/diagnostics_log.h M src/kudu/server/server_base.cc M src/kudu/tools/kudu-tool-test.cc M src/kudu/tools/tool_action.cc M src/kudu/tools/tool_action.h M src/kudu/tools/tool_action_master.cc M src/kudu/tools/tool_action_tserver.cc M src/kudu/tools/tool_main.cc M src/kudu/tserver/CMakeLists.txt M src/kudu/tserver/tablet_server.h M src/kudu/tserver/tablet_server_main.cc A src/kudu/tserver/tablet_server_runner.cc A src/kudu/tserver/tablet_server_runner.h M src/kudu/util/flag_tags-test.cc M src/kudu/util/flags-test.cc M src/kudu/util/flags.cc M src/kudu/util/flags.h M src/kudu/util/logging.cc M src/kudu/util/logging.h M src/kudu/util/minidump.cc M src/kudu/util/rolling_log-test.cc M src/kudu/util/rolling_log.cc M src/kudu/util/rolling_log.h 29 files changed, 439 insertions(+), 187 deletions(-) Approvals: Grant Henke: Verified Adar Dembo: Looks good to me, approved Andrew Wong: Looks good to me, approved Alexey Serbin: Looks good to me, but someone else must approve -- To view, visit http://gerrit.cloudera.org:8080/12517 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I3717cbac930b3506a76f7a51388c64afbcbb480e Gerrit-Change-Number: 12517 Gerrit-PatchSet: 26 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Greg Solovyev <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]>
