Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12517 )
Change subject: [tools] Support running the master and tablet server via the kudu binary ...................................................................... Patch Set 23: (2 comments) http://gerrit.cloudera.org:8080/#/c/12517/23//COMMIT_MSG Commit Message: PS23: > Do you feel strongly about this being broken up? It would take some effort I don't feel strongly about breaking this patch into few. If it seems hard, maybe it's OK to have as is, especially if you don't see any benefits from breaking this patch into few pieces. http://gerrit.cloudera.org:8080/#/c/12517/23/src/kudu/tserver/tablet_server_runner.cc File src/kudu/tserver/tablet_server_runner.cc: http://gerrit.cloudera.org:8080/#/c/12517/23/src/kudu/tserver/tablet_server_runner.cc@81 PS23, Line 81: } > It would be an unreachable statement. We just run until terminated. Yep, but wouldn't compiler produce any warning messages about the missing return statement? -- To view, visit http://gerrit.cloudera.org:8080/12517 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3717cbac930b3506a76f7a51388c64afbcbb480e Gerrit-Change-Number: 12517 Gerrit-PatchSet: 23 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Greg Solovyev <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Mon, 13 Jan 2020 17:08:12 +0000 Gerrit-HasComments: Yes
