Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14993 )

Change subject: [docker] Adjust entrypoint variable to be more composable
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/14993/2/docker/kudu-entrypoint.sh
File docker/kudu-entrypoint.sh:

http://gerrit.cloudera.org:8080/#/c/14993/2/docker/kudu-entrypoint.sh@60
PS2, Line 60:  --use_hybrid_clock=false"
> Users can configure it to be on. I want to make that the default too, but o
I see.  Yes, I think that makes sense, but there are some difference there 
still.

Using system_unsync time source is perfectly safe if all containers are at the 
same host or clocks for docker containers are not far off from each other (at 
least, by default the tolerated error is about 10 seconds).  Not using hybrid 
clock restricts functionality: at least, snapshot scans are no longer 
available, IIRC.



--
To view, visit http://gerrit.cloudera.org:8080/14993
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3451b3bb2d398f8e0bdea881103b6d4a74cb753
Gerrit-Change-Number: 14993
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Grant Henke <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 14 Jan 2020 22:37:10 +0000
Gerrit-HasComments: Yes

Reply via email to