Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15031 )
Change subject: [build] Make IWYU scipts compatible with Python 3 ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/15031/2/build-support/iwyu.py File build-support/iwyu.py: http://gerrit.cloudera.org:8080/#/c/15031/2/build-support/iwyu.py@178 PS2, Line 178: stream = BytesIO(iwyu_output) this isn't working for me on python 2.7 -- it seems like 'output' here is a unicode object (since you used decode on line 130) so this needs to be StringIO -- To view, visit http://gerrit.cloudera.org:8080/15031 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I979e96f66261146571ffc45f8222ad0fc15d1073 Gerrit-Change-Number: 15031 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Thu, 16 Jan 2020 06:39:30 +0000 Gerrit-HasComments: Yes
