Todd Lipcon has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14874 )

Change subject: memrowset: small optimizations for scanning
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/14874/1/src/kudu/tablet/cbtree-test.cc
File src/kudu/tablet/cbtree-test.cc:

http://gerrit.cloudera.org:8080/#/c/14874/1/src/kudu/tablet/cbtree-test.cc@754
PS1, Line 754:   gscoped_ptr<CBTreeIterator<BTreeTraits> > iter(
> Wanna modernize while you're here?
Done


http://gerrit.cloudera.org:8080/#/c/14874/1/src/kudu/tablet/cbtree-test.cc@797
PS1, Line 797:         int64_t count = 0, total_len = 0;
> warning: multiple declarations in a single statement reduces readability [r
Done


http://gerrit.cloudera.org:8080/#/c/14874/1/src/kudu/tablet/cbtree-test.cc@808
PS1, Line 808:         int64_t count = 0, total_len = 0;
> warning: multiple declarations in a single statement reduces readability [r
Done



--
To view, visit http://gerrit.cloudera.org:8080/14874
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia44b34606439625fbbbcc83e3652455a8894a0b3
Gerrit-Change-Number: 14874
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-Comment-Date: Thu, 16 Jan 2020 21:27:36 +0000
Gerrit-HasComments: Yes

Reply via email to