Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15036 )
Change subject: [client] support resolve one master address to multiple addresses ...................................................................... Patch Set 4: (2 comments) > As for the C++ Client, I think it will take the last responding leader master > as the leader master. Looking at the code in master_rpc.cc, it looks like the first leader wins (like in the Java client). That's because the first response from a leader will set leader_idx_ and completed_, causing future responses to return early and not touch the RPC state. http://gerrit.cloudera.org:8080/#/c/15036/4/java/kudu-client/src/main/java/org/apache/kudu/client/ConnectToCluster.java File java/kudu-client/src/main/java/org/apache/kudu/client/ConnectToCluster.java: http://gerrit.cloudera.org:8080/#/c/15036/4/java/kudu-client/src/main/java/org/apache/kudu/client/ConnectToCluster.java@186 PS4, Line 186: LOG.info("Resolve the host address {} to {}, and try to connect each of them.", : hostAndPort.getHost(), inetAddrs); Can you reword this with the same message you used in the C++ client? http://gerrit.cloudera.org:8080/#/c/15036/4/src/kudu/client/client-internal.cc File src/kudu/client/client-internal.cc: http://gerrit.cloudera.org:8080/#/c/15036/4/src/kudu/client/client-internal.cc@688 PS4, Line 688: "Connecting to each to them.", As per Bankim's earlier suggestion: "Connecting to each one of them." Note that you need to add a space between the period of the previous sentence and this one. -- To view, visit http://gerrit.cloudera.org:8080/15036 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie242bc1331596902fa16f1c6d1b439d78b73977a Gerrit-Change-Number: 15036 Gerrit-PatchSet: 4 Gerrit-Owner: Yifan Zhang <chinazhangyi...@163.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Bankim Bhavsar <ban...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <chinazhangyi...@163.com> Gerrit-Comment-Date: Fri, 17 Jan 2020 09:05:10 +0000 Gerrit-HasComments: Yes
