Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15059 )
Change subject: webserver: use faster gzip compression ...................................................................... Patch Set 1: (1 comment) > Patch Set 1: Code-Review+2 > > (1 comment) http://gerrit.cloudera.org:8080/#/c/15059/1/src/kudu/util/zlib.cc File src/kudu/util/zlib.cc: http://gerrit.cloudera.org:8080/#/c/15059/1/src/kudu/util/zlib.cc@76 PS1, Line 76: Status CompressLevel(Slice input, int level, ostream* out) { > Could DCHECK that level is between 1 and 9. Not a huge deal though as defla yea, I thought about doing that, but figured I'd let zlib do its own error checking in case they add more levels at some point down the road. -- To view, visit http://gerrit.cloudera.org:8080/15059 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If97d883483a7313bd5496af68b17e968a5223b1a Gerrit-Change-Number: 15059 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Fri, 17 Jan 2020 21:06:15 +0000 Gerrit-HasComments: Yes
