Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15081 )
Change subject: file cache: support alternate open modes ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/15081/1/src/kudu/fs/log_block_manager.cc File src/kudu/fs/log_block_manager.cc: http://gerrit.cloudera.org:8080/#/c/15081/1/src/kudu/fs/log_block_manager.cc@805 PS1, Line 805: } while (PREDICT_FALSE(metadata_status.IsAlreadyPresent() || : data_status.IsAlreadyPresent())); Is it possible this cycle run infinitely if the file got some sort of fs-level error or has chflags/etc. set? http://gerrit.cloudera.org:8080/#/c/15081/1/src/kudu/util/file_cache.cc File src/kudu/util/file_cache.cc: http://gerrit.cloudera.org:8080/#/c/15081/1/src/kudu/util/file_cache.cc@557 PS1, Line 557: DCHECK(!FindDescriptorUnlocked(file_name, FindMode::DONT_CREATE, : &rwf_descs_, &ignored)); nit: wrap into #ifndef NDEBUG ... #endif as for the OpenFile(..., shared_ptr<RWFile>) method above? -- To view, visit http://gerrit.cloudera.org:8080/15081 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie167302ef85b8e1a40fbb89a7742e2cbb43bcec3 Gerrit-Change-Number: 15081 Gerrit-PatchSet: 1 Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 21 Jan 2020 23:35:22 +0000 Gerrit-HasComments: Yes
