Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15081 )
Change subject: file cache: support alternate open modes ...................................................................... Patch Set 3: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/15081/1/src/kudu/util/file_cache.cc File src/kudu/util/file_cache.cc: http://gerrit.cloudera.org:8080/#/c/15081/1/src/kudu/util/file_cache.cc@360 PS1, Line 360: : // A descriptor adhering to the RandomAccessFile interface (i > Yeah I need to change this; the crappy hack I used was racy. Thanks Yeah, not the prettiest code, but I'm also not sure if there's a better way. -- To view, visit http://gerrit.cloudera.org:8080/15081 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie167302ef85b8e1a40fbb89a7742e2cbb43bcec3 Gerrit-Change-Number: 15081 Gerrit-PatchSet: 3 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Wed, 22 Jan 2020 21:49:05 +0000 Gerrit-HasComments: Yes
