Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15091 )
Change subject: KUDU-3011 p7: add tool to quiesce server ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/15091/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15091/5//COMMIT_MSG@10 PS5, Line 10: kudu tserver try_quiescing > I haven't looked into the details yet, but just a high-level suggestion. Do you mean 'status' should check the number of leaders and number of scanners, or it should return whether the tserver is quiescing? If the former, I don't think there's much value in separating 'start' and 'status', which is essentially what 'try_quiescing' is. And if the latter, I'm not sure there's value in it either -- it wouldn't be that useful for a rolling restart, though it might be nice for observability. I'm open to renaming and rejiggering for the 'quiesce' subcommand though. -- To view, visit http://gerrit.cloudera.org:8080/15091 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I89657808cc2b0afc4e1b37ce75937ab12e098d9c Gerrit-Change-Number: 15091 Gerrit-PatchSet: 5 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 23 Jan 2020 00:00:23 +0000 Gerrit-HasComments: Yes
