Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15091 )
Change subject: KUDU-3011 p7: add tool to quiesce server ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/15091/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15091/5//COMMIT_MSG@10 PS5, Line 10: kudu tserver try_quiescing > Do you mean 'status' should check the number of leaders and number of scann It's possible to split 'status' into multiple things, if necessary. How about: start -- start quiescing status -- get info on whether the server is quiescing or not, and also output stats on number of leaders and scanners, if any (the latter might be toggled on/off by an extra flag) done -- if quiescing has started, return 0 if no leaders/scanners are hosted by the server, otherwise return -1 if the quiescing hasn't started yet, return 1 if some scanners and/or leader replicas are still there (or it might be min(255, num_of_leaders + num_of_scanners) or something like that, and it might be controlled by flags as well, like return the total count of those entities or particular entities according to the flag) stop -- stop quiescing 'done' might have an extra option to await for server to complete the process before returning (with additional control of the timeout for the process, and have unlimited timeout option as well) What do you think? -- To view, visit http://gerrit.cloudera.org:8080/15091 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I89657808cc2b0afc4e1b37ce75937ab12e098d9c Gerrit-Change-Number: 15091 Gerrit-PatchSet: 5 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 23 Jan 2020 03:53:22 +0000 Gerrit-HasComments: Yes
