Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15091 )
Change subject: KUDU-3011 p7: add tool to quiesce server ...................................................................... Patch Set 10: -Code-Review (3 comments) http://gerrit.cloudera.org:8080/#/c/15091/10/src/kudu/tools/tool_action_tserver.cc File src/kudu/tools/tool_action_tserver.cc: http://gerrit.cloudera.org:8080/#/c/15091/10/src/kudu/tools/tool_action_tserver.cc@53 PS10, Line 53: error_if_not_fully_quiesced What's the use case for that and why does 'start' depends on the final state of quiescing? http://gerrit.cloudera.org:8080/#/c/15091/10/src/kudu/tools/tool_action_tserver.cc@364 PS10, Line 364: redirected to other servers nit: maybe, 'rejected' or 'retried at other servers' If I understand correctly, a quiescent tablet server does not do any 'redirection' per se. http://gerrit.cloudera.org:8080/#/c/15091/10/src/kudu/tools/tool_test_util.h File src/kudu/tools/tool_test_util.h: http://gerrit.cloudera.org:8080/#/c/15091/10/src/kudu/tools/tool_test_util.h@48 PS10, Line 48: tool nit: run ? -- To view, visit http://gerrit.cloudera.org:8080/15091 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I89657808cc2b0afc4e1b37ce75937ab12e098d9c Gerrit-Change-Number: 15091 Gerrit-PatchSet: 10 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 23 Jan 2020 20:12:21 +0000 Gerrit-HasComments: Yes
