Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15113 )
Change subject: KUDU-3046: deflake TabletServerQuiescingITest ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/15113/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15113/3//COMMIT_MSG@10 PS3, Line 10: - Slowness in TSAN mode along with a low Raft timeout meant workloads : would fail to even create tablets. : - Addressed this by increasing the heartbeat interval in TSAN mode. This happens to us quite often. How do you feel about adding a DCHECK or something equivalent to enforce that, in TSAN, the Raft heartbeat interval isn't below some threshold? http://gerrit.cloudera.org:8080/#/c/15113/3/src/kudu/integration-tests/tablet_server_quiescing-itest.cc File src/kudu/integration-tests/tablet_server_quiescing-itest.cc: http://gerrit.cloudera.org:8080/#/c/15113/3/src/kudu/integration-tests/tablet_server_quiescing-itest.cc@a197 PS3, Line 197: Why don't want to lower the heartbeat interval in this test any more? http://gerrit.cloudera.org:8080/#/c/15113/3/src/kudu/integration-tests/tablet_server_quiescing-itest.cc@699 PS3, Line 699: ignore_result(LeaderStepDown(ts_and_details.second, tablet_id, kLeaderTimeout)); Should we ASSERT that we succeeded at least once somewhere? -- To view, visit http://gerrit.cloudera.org:8080/15113 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3f9ef531062c4b66648840e04962070768fbad5d Gerrit-Change-Number: 15113 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 28 Jan 2020 04:35:58 +0000 Gerrit-HasComments: Yes
