Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15113 )
Change subject: KUDU-3046: deflake TabletServerQuiescingITest ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/15113/3/src/kudu/integration-tests/tablet_server_quiescing-itest.cc File src/kudu/integration-tests/tablet_server_quiescing-itest.cc: http://gerrit.cloudera.org:8080/#/c/15113/3/src/kudu/integration-tests/tablet_server_quiescing-itest.cc@a197 PS3, Line 197: > Why don't want to lower the heartbeat interval in this test any more? Yup, we have some test which run with ranges 25ms -- 200ms hearbeat interval. It seems 25ms might be a good option, at least 50ms seems be viable for non-sanitizer builds. http://gerrit.cloudera.org:8080/#/c/15113/3/src/kudu/integration-tests/tablet_server_quiescing-itest.cc@699 PS3, Line 699: ignore_result(LeaderStepDown(ts_and_details.second, tablet_id, kLeaderTimeout)); > Should we ASSERT that we succeeded at least once somewhere? Indeed, what if the tablet servers were in election cycle already when a request to quiesce arrived? They could vote, and then receive the quiesce request. The step-down request might arrive to the leader before it got 'yes' votes from the followers, right? Would it help to wait for about 2x of time necessary to elect a leader after sending last quiesce request and before first LeaderStepDown() call? -- To view, visit http://gerrit.cloudera.org:8080/15113 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3f9ef531062c4b66648840e04962070768fbad5d Gerrit-Change-Number: 15113 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 28 Jan 2020 04:55:07 +0000 Gerrit-HasComments: Yes
