Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15115 )
Change subject: [tests] fix flakiness in RaftConsensusNonVoterITest ...................................................................... Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/15115/1/src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc File src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc: http://gerrit.cloudera.org:8080/#/c/15115/1/src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc@861 PS1, Line 861: ASSERT_EVENTUALLY([&]() { : const MonoDelta kElectionTimeout = MonoDelta::FromSeconds(3); : ASSERT_OK(StartElection( : tablet_replicas_.begin()->second, tablet_id_, kElectionTimeout)); : ASSERT_OK(WaitUntilLeader( : tablet_replicas_.begin()->second, tablet_id_, kElectionTimeout)); : }); Should each of these be in its own ASSERT_EVENTUALLY? Or do we want to start a new election if WaitUntilLeader fails? -- To view, visit http://gerrit.cloudera.org:8080/15115 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia76e4ea57f2f9d4251ad3cbed47267266fee7e28 Gerrit-Change-Number: 15115 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 28 Jan 2020 09:37:52 +0000 Gerrit-HasComments: Yes
