Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15115 )
Change subject: [tests] fix flakiness in RaftConsensusNonVoterITest ...................................................................... Patch Set 1: (1 comment) Thank you for the review! http://gerrit.cloudera.org:8080/#/c/15115/1/src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc File src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc: http://gerrit.cloudera.org:8080/#/c/15115/1/src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc@861 PS1, Line 861: ASSERT_EVENTUALLY([&]() { : const MonoDelta kElectionTimeout = MonoDelta::FromSeconds(3); : ASSERT_OK(StartElection( : tablet_replicas_.begin()->second, tablet_id_, kElectionTimeout)); : ASSERT_OK(WaitUntilLeader( : tablet_replicas_.begin()->second, tablet_id_, kElectionTimeout)); : }); > Should each of these be in its own ASSERT_EVENTUALLY? Or do we want to star Yes, it's necessary to start a new election cycle if a new leader didn't come up after some time. From what I've seen in the logs of the failed scenarios, VoteRequest timed out and because the leader failure detector was not enabled, it would require to start another election round to succeed in finding a leader replica. -- To view, visit http://gerrit.cloudera.org:8080/15115 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia76e4ea57f2f9d4251ad3cbed47267266fee7e28 Gerrit-Change-Number: 15115 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 28 Jan 2020 17:57:23 +0000 Gerrit-HasComments: Yes
