Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15145 )
Change subject: WIP KUDU-1625: background op to GC ancient, empty rowsets ...................................................................... Patch Set 1: (3 comments) Thank you for taking this first step to address the long-standing issue. I don't have good understanding how compactions work in Kudu, so I left a couple of high-level comments. http://gerrit.cloudera.org:8080/#/c/15145/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15145/1//COMMIT_MSG@15 PS1, Line 15: later Probably meant 'earlier', no? http://gerrit.cloudera.org:8080/#/c/15145/1//COMMIT_MSG@19 PS1, Line 19: questions : around write amplification and compatibility with the existing : compactions strategies Is it possible to track the write activity on the tablet replica and make a decision to kick off GC of the empty rowsets if it has been more than some configurable time interval of inactivity AND no other 'regular' compaction is running? http://gerrit.cloudera.org:8080/#/c/15145/1//COMMIT_MSG@23 PS1, Line 23: less surprising Is it possible to outline what's still surprising even if having this GC-ing in place? A couple of corner cases, maybe. Also, should we expect the disk capacity to be reclaimed when deleting, say, all the rows in a table and no other updates after that? -- To view, visit http://gerrit.cloudera.org:8080/15145 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I696e2a29ea52ad4e54801b495c322bc371787124 Gerrit-Change-Number: 15145 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Fri, 31 Jan 2020 20:01:19 +0000 Gerrit-HasComments: Yes
