Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15145 )
Change subject: WIP KUDU-1625: background op to GC ancient, empty rowsets ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/15145/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15145/1//COMMIT_MSG@12 PS1, Line 12: - For the sake of simplicity on bootstrap, the rowset should not have a : DMS. I don't see a clear way to rebuild a DMS if the underlying DRS : has been deleted. > Not quite following this: if the rowset has a DMS and we decide to delete i My concern is around rebuilding the DMS from the WAL. I didn't look very hard, but I'm not sure what happens when we try to rebuild a DMS on a DRS that's been deleted. I punted on jumping down that rabbit hole and just left a TODO. http://gerrit.cloudera.org:8080/#/c/15145/1//COMMIT_MSG@23 PS1, Line 23: less surprising > Is it possible to outline what's still surprising even if having this GC-in Sure, the big one is that if the user deleted 50% of their table such that all their rowsets were not fully deleted, they wouldn't see any reclaimed space here. Yeah, the space would be reclaimed after 7 days (based on the ancient history mark) -- To view, visit http://gerrit.cloudera.org:8080/15145 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I696e2a29ea52ad4e54801b495c322bc371787124 Gerrit-Change-Number: 15145 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Fri, 31 Jan 2020 20:39:57 +0000 Gerrit-HasComments: Yes
