Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15141 )
Change subject: [doc] update on NTP clock synchronization ...................................................................... Patch Set 1: (47 comments) Thank you for the through review! http://gerrit.cloudera.org:8080/#/c/15141/1/docs/troubleshooting.adoc File docs/troubleshooting.adoc: http://gerrit.cloudera.org:8080/#/c/15141/1/docs/troubleshooting.adoc@110 PS1, Line 110: so-called > Nit: replace with 'the' Done http://gerrit.cloudera.org:8080/#/c/15141/1/docs/troubleshooting.adoc@115 PS1, Line 115: must > Nit: drop Done http://gerrit.cloudera.org:8080/#/c/15141/1/docs/troubleshooting.adoc@116 PS1, Line 116: threshold's > Nit: threshold Done http://gerrit.cloudera.org:8080/#/c/15141/1/docs/troubleshooting.adoc@142 PS1, Line 142: : > Nit: replace with comma Done http://gerrit.cloudera.org:8080/#/c/15141/1/docs/troubleshooting.adoc@162 PS1, Line 162: upon machine's bootstrap > Nit: "when the machine starts" Done http://gerrit.cloudera.org:8080/#/c/15141/1/docs/troubleshooting.adoc@164 PS1, Line 164: less > smaller Done http://gerrit.cloudera.org:8080/#/c/15141/1/docs/troubleshooting.adoc@166 PS1, Line 166: make the clock synchronized with the true time > synchronize the clock. Done http://gerrit.cloudera.org:8080/#/c/15141/1/docs/troubleshooting.adoc@168 PS1, Line 168: the > drop 'the' Done http://gerrit.cloudera.org:8080/#/c/15141/1/docs/troubleshooting.adoc@169 PS1, Line 169: it's about > we're referring to Done http://gerrit.cloudera.org:8080/#/c/15141/1/docs/troubleshooting.adoc@168 PS1, Line 168: Network : Time Protocol (NTP) > This definition should be used the first time NTP is mentioned. Done http://gerrit.cloudera.org:8080/#/c/15141/1/docs/troubleshooting.adoc@175 PS1, Line 175: information about the > drop Done http://gerrit.cloudera.org:8080/#/c/15141/1/docs/troubleshooting.adoc@176 PS1, Line 176: into > in Done http://gerrit.cloudera.org:8080/#/c/15141/1/docs/troubleshooting.adoc@177 PS1, Line 177: information about the > drop Done http://gerrit.cloudera.org:8080/#/c/15141/1/docs/troubleshooting.adoc@183 PS1, Line 183: if > if the Done http://gerrit.cloudera.org:8080/#/c/15141/1/docs/troubleshooting.adoc@184 PS1, Line 184: It looks like the following > This manifests as Done http://gerrit.cloudera.org:8080/#/c/15141/1/docs/troubleshooting.adoc@185 PS1, Line 185: report > claim that Done http://gerrit.cloudera.org:8080/#/c/15141/1/docs/troubleshooting.adoc@186 PS1, Line 186: as > is Done http://gerrit.cloudera.org:8080/#/c/15141/1/docs/troubleshooting.adoc@186 PS1, Line 186: reports > claims that Done http://gerrit.cloudera.org:8080/#/c/15141/1/docs/troubleshooting.adoc@188 PS1, Line 188: mentioned > the one mentioned Done http://gerrit.cloudera.org:8080/#/c/15141/1/docs/troubleshooting.adoc@189 PS1, Line 189: As one can see in > According to Done http://gerrit.cloudera.org:8080/#/c/15141/1/docs/troubleshooting.adoc@190 PS1, Line 190: , when in normal mode > . Without `-x`, the NTP server would do a step adjustment instead: Done http://gerrit.cloudera.org:8080/#/c/15141/1/docs/troubleshooting.adoc@190 PS1, Line 190: slewing the clock all the time > to only slew the clock Done http://gerrit.cloudera.org:8080/#/c/15141/1/docs/troubleshooting.adoc@190 PS1, Line 190: makes > configures Done http://gerrit.cloudera.org:8080/#/c/15141/1/docs/troubleshooting.adoc@204 PS1, Line 204: to > drop Done http://gerrit.cloudera.org:8080/#/c/15141/1/docs/troubleshooting.adoc@207 PS1, Line 207: An extra > More Done http://gerrit.cloudera.org:8080/#/c/15141/1/docs/troubleshooting.adoc@213 PS1, Line 213: When > When the Done http://gerrit.cloudera.org:8080/#/c/15141/1/docs/troubleshooting.adoc@214 PS1, Line 214: which > with a local clock that is synchronized Done http://gerrit.cloudera.org:8080/#/c/15141/1/docs/troubleshooting.adoc@236 PS1, Line 236: non-synchronized > unsynchronized Done http://gerrit.cloudera.org:8080/#/c/15141/1/docs/troubleshooting.adoc@252 PS1, Line 252: In this case > Because of that Done http://gerrit.cloudera.org:8080/#/c/15141/1/docs/troubleshooting.adoc@261 PS1, Line 261: synchronised to NTP server (172.18.7.3) at stratum 4 > Trailing whitespace here, but if it's copied verbatim from the output it's Done http://gerrit.cloudera.org:8080/#/c/15141/1/docs/troubleshooting.adoc@267 PS1, Line 267: immediately translates into the same > reflect the Done http://gerrit.cloudera.org:8080/#/c/15141/1/docs/troubleshooting.adoc@268 PS1, Line 268: a > drop 'a' Done http://gerrit.cloudera.org:8080/#/c/15141/1/docs/troubleshooting.adoc@268 PS1, Line 268: how > drop 'how' Done http://gerrit.cloudera.org:8080/#/c/15141/1/docs/troubleshooting.adoc@270 PS1, Line 270: its > Replace with 'the' Done http://gerrit.cloudera.org:8080/#/c/15141/1/docs/troubleshooting.adoc@273 PS1, Line 273: result synchronization > synchronization status Done http://gerrit.cloudera.org:8080/#/c/15141/1/docs/troubleshooting.adoc@276 PS1, Line 276: both > either Done http://gerrit.cloudera.org:8080/#/c/15141/1/docs/troubleshooting.adoc@311 PS1, Line 311: Kudu has been tested most thoroughly using `ntpd` and use of : `chrony` is considered experimental. > It'd be great if you dumped your chrony knowledge into this section too, th I added some information to reflect current status of the affairs in this area. http://gerrit.cloudera.org:8080/#/c/15141/1/docs/troubleshooting.adoc@324 PS1, Line 324: take > take a Done http://gerrit.cloudera.org:8080/#/c/15141/1/docs/troubleshooting.adoc@324 PS1, Line 324: clock > time Done http://gerrit.cloudera.org:8080/#/c/15141/1/docs/troubleshooting.adoc@325 PS1, Line 325: can synchronize > synchronizes Done http://gerrit.cloudera.org:8080/#/c/15141/1/docs/troubleshooting.adoc@332 PS1, Line 332: AWS/EC2 and GCE/GCP > Pick AWS/GCE or EC2/GCP; no need to mention both variants of each cloud. Done http://gerrit.cloudera.org:8080/#/c/15141/1/docs/troubleshooting.adoc@368 PS1, Line 368: TIP: After configuring `ntpd`, first run `ntpdate` tool with the same set of > Doesn't some of this duplicate the first NTP best practice? Yes, it's true: there is some duplication. But I think it wouldn't hurt to explain how to run it manually, if needed. Another important piece here is to run the tool with the same set of reference servers as used for ntpd. http://gerrit.cloudera.org:8080/#/c/15141/1/docs/troubleshooting.adoc@370 PS1, Line 370: the > Drop 'the' Done http://gerrit.cloudera.org:8080/#/c/15141/1/docs/troubleshooting.adoc@370 PS1, Line 370: code > status Done http://gerrit.cloudera.org:8080/#/c/15141/1/docs/troubleshooting.adoc@371 PS1, Line 371: the > Drop 'the' Done http://gerrit.cloudera.org:8080/#/c/15141/1/docs/troubleshooting.adoc@372 PS1, Line 372: firewall > Would be good to mention that NTP traffic is typically on UDP port 123. Done http://gerrit.cloudera.org:8080/#/c/15141/1/docs/troubleshooting.adoc@373 PS1, Line 373: start > start the Done -- To view, visit http://gerrit.cloudera.org:8080/15141 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib3b1485b6df846a3286f52003684386e59e972ac Gerrit-Change-Number: 15141 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 31 Jan 2020 20:44:27 +0000 Gerrit-HasComments: Yes
