Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15034 )
Change subject: KUDU-2483 Integrate BlockBloomFilter with ColumnPredicate on server side ...................................................................... Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/15034/11/src/kudu/common/wire_protocol.cc File src/kudu/common/wire_protocol.cc: http://gerrit.cloudera.org:8080/#/c/15034/11/src/kudu/common/wire_protocol.cc@623 PS11, Line 623: auto allocator = arena->NewObject<ArenaBlockBloomFilterBufferAllocator>(arena); IIUC, it's OK to "orphan" the allocator object (previously we would faithfully preserve it alongside the BlockBloomFilters) because: 1. The arena used to allocate the bfs is preserved for the lifetime of the scan, which de facto exceeds the lifetime of the bfs themselves. 2. We don't need to make any further allocations in the bfs themselves, so it's OK if their allocator pointers are garbage. That last point gives me pause; it seems somewhat error prone to have live objects associated to garbage data. Perhaps we could mutate the bfs at this point to nullify their allocator pointers, so that any future allocations trigger a DCHECK? -- To view, visit http://gerrit.cloudera.org:8080/15034 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7ecfd67e9c5fbe459c5b4aed91e0be2a194d433a Gerrit-Change-Number: 15034 Gerrit-PatchSet: 11 Gerrit-Owner: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yao Xu <[email protected]> Gerrit-Reviewer: ZhangYao <[email protected]> Gerrit-Reviewer: helifu <[email protected]> Gerrit-Comment-Date: Fri, 31 Jan 2020 23:15:14 +0000 Gerrit-HasComments: Yes
