Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15034 )
Change subject: KUDU-2483 Integrate BlockBloomFilter with ColumnPredicate on server side ...................................................................... Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/15034/11/src/kudu/common/wire_protocol.cc File src/kudu/common/wire_protocol.cc: http://gerrit.cloudera.org:8080/#/c/15034/11/src/kudu/common/wire_protocol.cc@623 PS11, Line 623: auto allocator = arena->NewObject<ArenaBlockBloomFilterBufferAllocator>(arena); > IIUC, it's OK to "orphan" the allocator object (previously we would faithfu Looking at the code again, I'm a little confused as to how this works, because the BBF destructor leads to a call to buffer_allocator_->FreeBuffer(). If 'allocator' here has popped off the stack, why doesn't the FreeBuffer() call corrupt memory or crash the process? -- To view, visit http://gerrit.cloudera.org:8080/15034 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7ecfd67e9c5fbe459c5b4aed91e0be2a194d433a Gerrit-Change-Number: 15034 Gerrit-PatchSet: 11 Gerrit-Owner: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yao Xu <[email protected]> Gerrit-Reviewer: ZhangYao <[email protected]> Gerrit-Reviewer: helifu <[email protected]> Gerrit-Comment-Date: Fri, 31 Jan 2020 23:17:55 +0000 Gerrit-HasComments: Yes
