Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15161 )
Change subject: [clock] auto-selection of time source ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/15161/1/src/kudu/clock/hybrid_clock.cc File src/kudu/clock/hybrid_clock.cc: http://gerrit.cloudera.org:8080/#/c/15161/1/src/kudu/clock/hybrid_clock.cc@175 PS1, Line 175: const auto s = detector.Detect(&md); It'd be nice to avoid "double detection" (here and in BuiltInNtp when --builtin_ntp_client_enable_auto_config_in_cloud is set) as that'll slow down startup. On a related note, should --time_source=auto imply --builtin_ntp_client_enable_auto_config_in_cloud? Should we remove --builtin_ntp_client_enable_auto_config_in_cloud altogether and expect that if the time source is auto, the user wants us to set up the built-in NTP server list too? http://gerrit.cloudera.org:8080/#/c/15161/1/src/kudu/clock/hybrid_clock.cc@180 PS1, Line 180: time_service_.reset(new clock::BuiltInNtp); Instead of actually constructing time_service_, could we use the detection results to convert the gflag value of 'auto' into one of 'builtin', 'system', or 'system_unsync', and then use the existing if/elseif/else to construct the time_service_? -- To view, visit http://gerrit.cloudera.org:8080/15161 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If9f2bc94f4a1ad32fe365d4f6f0707913fb476a4 Gerrit-Change-Number: 15161 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 05 Feb 2020 18:55:13 +0000 Gerrit-HasComments: Yes
