Volodymyr Verovkin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15161 )
Change subject: [clock] introduce time source auto selection ...................................................................... Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/15161/6/src/kudu/clock/hybrid_clock-test.cc File src/kudu/clock/hybrid_clock-test.cc: http://gerrit.cloudera.org:8080/#/c/15161/6/src/kudu/clock/hybrid_clock-test.cc@382 PS6, Line 382: clock_.reset(new HybridClock); Why not to use std::make_unique() ? http://gerrit.cloudera.org:8080/#/c/15161/6/src/kudu/clock/hybrid_clock.cc File src/kudu/clock/hybrid_clock.cc: http://gerrit.cloudera.org:8080/#/c/15161/6/src/kudu/clock/hybrid_clock.cc@91 PS6, Line 91: TIME_SOURCE_AUTO ", " Looks a bit cryptic. I suggest to replace macro with text (here and below). http://gerrit.cloudera.org:8080/#/c/15161/6/src/kudu/clock/hybrid_clock.cc@466 PS6, Line 466: case TimeSource::SYSTEM_NTP_SYNC: Should it be wrapped into #if defined(KUDU_HAS_SYSTEM_TIME_SOURCE) ? -- To view, visit http://gerrit.cloudera.org:8080/15161 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If9f2bc94f4a1ad32fe365d4f6f0707913fb476a4 Gerrit-Change-Number: 15161 Gerrit-PatchSet: 6 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Volodymyr Verovkin <[email protected]> Gerrit-Comment-Date: Fri, 07 Feb 2020 20:40:25 +0000 Gerrit-HasComments: Yes
