Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15174 )
Change subject: [rpc-test] fix flaky TestCancellation ...................................................................... Patch Set 1: (3 comments) Thanks for doing this. http://gerrit.cloudera.org:8080/#/c/15174/1//COMMIT_MSG Commit Message: PS1: It's worth noting that the failure always seemed to happen when cancellation was injected into the SENT phase of the RPC. Any idea why cancellation during that particular phase would sometimes time out vs. the other phases? http://gerrit.cloudera.org:8080/#/c/15174/1//COMMIT_MSG@14 PS1, Line 14: persmissive permissive http://gerrit.cloudera.org:8080/#/c/15174/1/src/kudu/rpc/rpc-test-base.h File src/kudu/rpc/rpc-test-base.h: http://gerrit.cloudera.org:8080/#/c/15174/1/src/kudu/rpc/rpc-test-base.h@568 PS1, Line 568: can Nit: cancel? can cancel? Not sure what's missing here. -- To view, visit http://gerrit.cloudera.org:8080/15174 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If140a9215c94d781c2c61ec30b18d2d67d80310a Gerrit-Change-Number: 15174 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 06 Feb 2020 21:28:23 +0000 Gerrit-HasComments: Yes
