Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/15174 )
Change subject: [rpc-test] fix flaky TestCancellation ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/15174/1//COMMIT_MSG Commit Message: PS1: > It's worth noting that the failure always seemed to happen when cancellatio I believe that's just because its the phase where the rpc is furthest along towards getting sent/a response received, so it leaves less time for the cancellation to actually be executed. http://gerrit.cloudera.org:8080/#/c/15174/1//COMMIT_MSG@14 PS1, Line 14: permissive > permissive Done http://gerrit.cloudera.org:8080/#/c/15174/1/src/kudu/rpc/rpc-test-base.h File src/kudu/rpc/rpc-test-base.h: http://gerrit.cloudera.org:8080/#/c/15174/1/src/kudu/rpc/rpc-test-base.h@568 PS1, Line 568: can > Nit: cancel? can cancel? Not sure what's missing here. Done http://gerrit.cloudera.org:8080/#/c/15174/1/src/kudu/rpc/rpc-test-base.h@570 PS1, Line 570: EXPECT_TRUE(s.IsAborted() || s.IsTimedOut()) > nit: could you add ' << s.ToString()' ? That can help in troubleshooting i That's already covered by the LOG(INFO) right below this, but I added it here too for extra convenience. -- To view, visit http://gerrit.cloudera.org:8080/15174 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If140a9215c94d781c2c61ec30b18d2d67d80310a Gerrit-Change-Number: 15174 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Comment-Date: Thu, 06 Feb 2020 22:54:44 +0000 Gerrit-HasComments: Yes
