Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15191 )
Change subject: [java] Fix various build warnings ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/15191/3/java/kudu-client/src/main/java/org/apache/kudu/client/CallResponse.java File java/kudu-client/src/main/java/org/apache/kudu/client/CallResponse.java: http://gerrit.cloudera.org:8080/#/c/15191/3/java/kudu-client/src/main/java/org/apache/kudu/client/CallResponse.java@161 PS3, Line 161: @Override : public boolean equals(Object o) { : return super.equals(o); : } : : @Override : public int hashCode() { : return super.hashCode(); : } By default, won't the parent's method be invoked anyways? http://gerrit.cloudera.org:8080/#/c/15191/3/java/kudu-client/src/main/java/org/apache/kudu/util/NetUtil.java File java/kudu-client/src/main/java/org/apache/kudu/util/NetUtil.java: http://gerrit.cloudera.org:8080/#/c/15191/3/java/kudu-client/src/main/java/org/apache/kudu/util/NetUtil.java@131 PS3, Line 131: new InetAddress[0]; Array of size 0. Why this change? Prevents NPE? Need to update Javadoc comment. http://gerrit.cloudera.org:8080/#/c/15191/3/java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/MessageIO.java File java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/MessageIO.java: http://gerrit.cloudera.org:8080/#/c/15191/3/java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/MessageIO.java@96 PS3, Line 96: String.format("unable to receive message, expected (%d) bytes " + : "but read (%d) bytes", size, read)); Wasn't the earlier formatting correct? http://gerrit.cloudera.org:8080/#/c/15191/3/java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/ProtocolHandler.java File java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/ProtocolHandler.java: http://gerrit.cloudera.org:8080/#/c/15191/3/java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/ProtocolHandler.java@36 PS3, Line 36: public abstract class ProtocolHandler<I extends Message, : O extends Message> I find earlier Request/Response generic types better for readability than I/O. -- To view, visit http://gerrit.cloudera.org:8080/15191 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I75649e6ad26eec1942811fcb790fc9a2c0866a6b Gerrit-Change-Number: 15191 Gerrit-PatchSet: 3 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 10 Feb 2020 21:29:48 +0000 Gerrit-HasComments: Yes
