Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15191 )
Change subject: [java] Fix various build warnings ...................................................................... Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/15191/3/java/config/spotbugs/excludeFilter.xml File java/config/spotbugs/excludeFilter.xml: http://gerrit.cloudera.org:8080/#/c/15191/3/java/config/spotbugs/excludeFilter.xml@115 PS3, Line 115: <!-- Often tests testing exceptions have "exception" in the name. --> Seems easy enough to address (later). http://gerrit.cloudera.org:8080/#/c/15191/3/java/config/spotbugs/excludeFilter.xml@239 PS3, Line 239: <!-- Reference equality is intended here. --> Not clear how the three <Bug> elements have to do with this. http://gerrit.cloudera.org:8080/#/c/15191/3/java/config/spotbugs/excludeFilter.xml@242 PS3, Line 242: <Bug pattern="BIT_ADD_OF_SIGNED_BYTE" /> : <Bug pattern="SF_SWITCH_FALLTHROUGH" /> : <Bug pattern="SF_SWITCH_NO_DEFAULT" /> You modified the code to disable checkstyle though; does that mean this is no longer needed? http://gerrit.cloudera.org:8080/#/c/15191/3/java/kudu-client/src/main/java/org/apache/kudu/util/NetUtil.java File java/kudu-client/src/main/java/org/apache/kudu/util/NetUtil.java: http://gerrit.cloudera.org:8080/#/c/15191/3/java/kudu-client/src/main/java/org/apache/kudu/util/NetUtil.java@131 PS3, Line 131: new InetAddress[0]; > Array of size 0. Why this change? Prevents NPE? Yeah I agree this looks fishy. Is it possible for getAllByName() to return an _empty list_? If so, then we should preserve the returning of null here, to differentiate between "no IP addresses" and "exception while resolving the name". http://gerrit.cloudera.org:8080/#/c/15191/3/java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/SubprocessExecutor.java File java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/SubprocessExecutor.java: http://gerrit.cloudera.org:8080/#/c/15191/3/java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/SubprocessExecutor.java@58 PS3, Line 58: // Exit the program with a nonzero status code, by throwing a runtime exception. : // if unexpected exception(s) are thrown by the reader or writer tasks. Comment needs to be rewritten. -- To view, visit http://gerrit.cloudera.org:8080/15191 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I75649e6ad26eec1942811fcb790fc9a2c0866a6b Gerrit-Change-Number: 15191 Gerrit-PatchSet: 3 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 10 Feb 2020 21:47:20 +0000 Gerrit-HasComments: Yes
