Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15122 )
Change subject: [client] KUDU-2483 Add IN Bloom filter predicate to C++ client ...................................................................... Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/15122/8/src/kudu/client/scan_predicate.h File src/kudu/client/scan_predicate.h: http://gerrit.cloudera.org:8080/#/c/15122/8/src/kudu/client/scan_predicate.h@31 PS8, Line 31: #include <cstddef> > Unlike cstdint, I couldn't evidence about cstddef being unavailable in olde Makes sense. I also ran a test on a CentOS 6.6 machine: [adar@ve0518 ~]$ g++ --version g++ (GCC) 4.4.7 20120313 (Red Hat 4.4.7-11) [adar@ve0518 ~]$ echo "#include <cstddef>" | g++ -c -x c++ - [adar@ve0518 ~]$ echo "#include <cstdint>" | g++ -c -x c++ - In file included from /usr/lib/gcc/x86_64-redhat-linux/4.4.7/../../../../include/c++/4.4.7/cstdint:35, from <stdin>:1: /usr/lib/gcc/x86_64-redhat-linux/4.4.7/../../../../include/c++/4.4.7/c++0x_warning.h:31:2: error: #error This file requires compiler and library support for the upcoming ISO C++ standard, C++0x. This support is currently experimental, and must be enabled with the -std=c++0x or -std=gnu++0x compiler options. -- To view, visit http://gerrit.cloudera.org:8080/15122 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4aa235a4c933ebce0bf3ec7fcb135098eccc4ea4 Gerrit-Change-Number: 15122 Gerrit-PatchSet: 8 Gerrit-Owner: Bankim Bhavsar <ban...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Bankim Bhavsar <ban...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yao Xu <ocla...@gmail.com> Gerrit-Reviewer: ZhangYao <triplesheep0...@gmail.com> Gerrit-Reviewer: helifu <hzhel...@corp.netease.com> Gerrit-Comment-Date: Wed, 12 Feb 2020 22:46:29 +0000 Gerrit-HasComments: Yes
