Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15215 )
Change subject: [clock] update on Clock interface ...................................................................... Patch Set 1: > > You added several new metrics. What is their purpose ? Should be > be > > documented ? > > This patch doesn't add any new metrics. The patch with a couple of new metrics is: https://gerrit.cloudera.org/#/c/15212/ I'm going to re-base it on top of https://gerrit.cloudera.org/#/c/15216/ , but feel free to leave feedback there as well. In short, the new metrics are documented by their instantiation macro (i.e. METRIC_DEFINE_gauge_<type>(), METRIC_DEFINE_histogram(), etc.), but in addition to that there is extra information on those in description of KUDU-3048. I'm going to add more color to KUDU-3048 in that regard as well (like documenting how the new metrics can be used). -- To view, visit http://gerrit.cloudera.org:8080/15215 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic4c1944d54bf50e54c06c12e2fb9e57fc452b877 Gerrit-Change-Number: 15215 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Volodymyr Verovkin <[email protected]> Gerrit-Comment-Date: Thu, 13 Feb 2020 16:49:55 +0000 Gerrit-HasComments: No
