Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15215 )
Change subject: [clock] update on Clock interface ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/15215/1/src/kudu/clock/logical_clock.h File src/kudu/clock/logical_clock.h: http://gerrit.cloudera.org:8080/#/c/15215/1/src/kudu/clock/logical_clock.h@51 PS1, Line 51: const scoped_refptr<MetricEntity>& metric_entity = {}); > OK, I guess I don't feel strongly enough to warrant a ton of LogicalClock-s Thank you for the feedback and fast review. If needed, we can address the unification of the constructors for LogicalClock() and HybridClock() in a separate changelist. -- To view, visit http://gerrit.cloudera.org:8080/15215 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic4c1944d54bf50e54c06c12e2fb9e57fc452b877 Gerrit-Change-Number: 15215 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Volodymyr Verovkin <[email protected]> Gerrit-Comment-Date: Fri, 14 Feb 2020 17:45:56 +0000 Gerrit-HasComments: Yes
