Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/4491 )
Change subject: KUDU-1563. Add an INSERT_IGNORE operation ...................................................................... Patch Set 23: (2 comments) http://gerrit.cloudera.org:8080/#/c/4491/20//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/4491/20//COMMIT_MSG@13 PS20, Line 13: In the future > The plan is to start with ignoring duplicate/missing PKs for all IGNORE ope Thanks for the details. I don't think you need to circulate a design doc; the JIRA has been open for some time and already has a detailed discussion. My concern largely stems from the C++ side of INSERT IGNORE, where the non-PIMPL'd approach will make it difficult to add e.g. per-op configurability. But, if we expect that future configurability will be session-based, there's no problem. http://gerrit.cloudera.org:8080/#/c/4491/23/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: http://gerrit.cloudera.org:8080/#/c/4491/23/src/kudu/client/client-test.cc@356 PS23, Line 356: static void InsertTestRows(KuduTable* table, KuduSession* session, Got two spaces here between 'static' and 'void'. -- To view, visit http://gerrit.cloudera.org:8080/4491 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5bfc35e9d27bd5e2d3375b68e6e4716ed671f36c Gerrit-Change-Number: 4491 Gerrit-PatchSet: 23 Gerrit-Owner: Brock Noland <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Brock Noland <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Tue, 18 Feb 2020 20:46:10 +0000 Gerrit-HasComments: Yes
