Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/4491 )
Change subject: KUDU-1563. Add an INSERT_IGNORE operation ...................................................................... Patch Set 23: (2 comments) http://gerrit.cloudera.org:8080/#/c/4491/20//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/4491/20//COMMIT_MSG@13 PS20, Line 13: In the future > Thanks for the details. I don't think you need to circulate a design doc; t I think it's reasonable to need per-op INSERT vs INSERT_IGNORE but not per-op configuration of what to ignore. I know of use cases like NiFi ingest where having ignore per-op is useful, but I don't know of use cases where configuring the errors to ignore per-op is. I think it's a reasonable plan to target session based config but adjust if we see other requirements before implementing. http://gerrit.cloudera.org:8080/#/c/4491/23/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: http://gerrit.cloudera.org:8080/#/c/4491/23/src/kudu/client/client-test.cc@356 PS23, Line 356: static void InsertTestRows(KuduTable* table, KuduSession* session, > Got two spaces here between 'static' and 'void'. Done -- To view, visit http://gerrit.cloudera.org:8080/4491 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5bfc35e9d27bd5e2d3375b68e6e4716ed671f36c Gerrit-Change-Number: 4491 Gerrit-PatchSet: 23 Gerrit-Owner: Brock Noland <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Brock Noland <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Tue, 18 Feb 2020 20:59:15 +0000 Gerrit-HasComments: Yes
