Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15252 )
Change subject: [util] fix debug builds in macOS ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Thanks for fixing this, Alexey! http://gerrit.cloudera.org:8080/#/c/15252/1/src/kudu/util/CMakeLists.txt File src/kudu/util/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/15252/1/src/kudu/util/CMakeLists.txt@29 PS1, Line 29: Is pb_util_proto necessary? Also hash_proto already specifies protobuf so is that necessary too? -- To view, visit http://gerrit.cloudera.org:8080/15252 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I48775a683bf47af5b97d44e14aa351eb54a69181 Gerrit-Change-Number: 15252 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Bankim Bhavsar <ban...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 20 Feb 2020 05:16:03 +0000 Gerrit-HasComments: Yes
