Hello Kudu Jenkins, Adar Dembo, Bankim Bhavsar,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15252
to look at the new patch set (#2).
Change subject: [util] fix debug builds in macOS
......................................................................
[util] fix debug builds in macOS
Prior to this patch, a debug build on macOS would fail with linker error
like below:
Undefined symbols for architecture x86_64:
"kudu::HashAlgorithm_IsValid(int)", referenced from:
kudu::BlockBloomFilterPB::MergePartialFromCodedStream(google::protobuf::io::CodedInputStream*)
in block_bloom_filter.pb.cc.o
kudu::BlockBloomFilterPB::set_hash_algorithm(kudu::HashAlgorithm) in
block_bloom_filter.pb.cc.o
"kudu::protobuf_kudu_2futil_2fhash_2eproto::InitDefaults()", referenced
from:
kudu::protobuf_kudu_2futil_2fblock_5fbloom_5ffilter_2eproto::TableStruct::InitDefaultsImpl()
in block_bloom_filter.pb.cc.o
"kudu::protobuf_kudu_2futil_2fhash_2eproto::AddDescriptors()", referenced
from:
kudu::protobuf_kudu_2futil_2fblock_5fbloom_5ffilter_2eproto::(anonymous
namespace)::AddDescriptorsImpl() in block_bloom_filter.pb.cc.o
"kudu::protobuf_kudu_2futil_2fpb_5futil_2eproto::InitDefaults()",
referenced from:
kudu::protobuf_kudu_2futil_2fblock_5fbloom_5ffilter_2eproto::TableStruct::InitDefaultsImpl()
in block_bloom_filter.pb.cc.o
"kudu::protobuf_kudu_2futil_2fpb_5futil_2eproto::AddDescriptors()",
referenced from:
kudu::protobuf_kudu_2futil_2fblock_5fbloom_5ffilter_2eproto::(anonymous
namespace)::AddDescriptorsImpl() in block_bloom_filter.pb.cc.o
ld: symbol(s) not found for architecture x86_64
and
Undefined symbols for architecture x86_64:
"kudu::protobuf_kudu_2futil_2fpb_5futil_2eproto::InitDefaults()",
referenced from:
kudu::protobuf_kudu_2futil_2fblock_5fbloom_5ffilter_2eproto::TableStruct::InitDefaultsImpl()
in block_bloom_filter.pb.cc.o
"kudu::protobuf_kudu_2futil_2fpb_5futil_2eproto::AddDescriptors()",
referenced from:
kudu::protobuf_kudu_2futil_2fblock_5fbloom_5ffilter_2eproto::(anonymous
namespace)::AddDescriptorsImpl() in block_bloom_filter.pb.cc.o
ld: symbol(s) not found for architecture x86_64
and
Undefined symbols for architecture x86_64:
"kudu::tablet::TestCFileSet::kRatio", referenced from:
kudu::tablet::TestCFileSet::WriteTestRowSet(int) in cfile_set-test.cc.o
kudu::tablet::TestCFileSet::FillBloomFilter(int,
kudu::BlockBloomFilter*, kudu::BlockBloomFilter*, kudu::BlockBloomFilter*,
kudu::BlockBloomFilter*) in cfile_set-test.cc.o
kudu::tablet::TestCFileSet::GetBloomFilterResult(int,
kudu::BlockBloomFilter*, kudu::BlockBloomFilter*, kudu::BlockBloomFilter*,
kudu::BlockBloomFilter*, std::__1::vector<unsigned long,
std::__1::allocator<unsigned long> >*, std::__1::vector<unsigned long,
std::__1::allocator<unsigned long> >*, std::__1::vector<unsigned long,
std::__1::allocator<unsigned long> >*, std::__1::vector<unsigned long,
std::__1::allocator<unsigned long> >*) in cfile_set-test.cc.o
ld: symbol(s) not found for architecture x86_64
This is a follow-up to 961888dd14e5bd306d3e5b741bc4443620617664.
Change-Id: I48775a683bf47af5b97d44e14aa351eb54a69181
---
M src/kudu/tablet/cfile_set-test.cc
M src/kudu/util/CMakeLists.txt
2 files changed, 4 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/52/15252/2
--
To view, visit http://gerrit.cloudera.org:8080/15252
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I48775a683bf47af5b97d44e14aa351eb54a69181
Gerrit-Change-Number: 15252
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ban...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
