Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15185 )
Change subject: [cpp] KUDU-2971: protobuf-based wrapper for subprocesses ...................................................................... Patch Set 12: (1 comment) > Patch Set 11: > > (1 comment) > > I'd rather we didn't merge a known flaky test. Now is a great time to address > it IMHO. Yeah same. The shutdown test was very flaky in release mode. I was mishandling shutdown of the queues, leaving some callbacks un-run. http://gerrit.cloudera.org:8080/#/c/15185/11/src/kudu/subprocess/server.cc File src/kudu/subprocess/server.cc: http://gerrit.cloudera.org:8080/#/c/15185/11/src/kudu/subprocess/server.cc@246 PS11, Line 246: earliest_call_within_deadline++) { > If all the calls expired, currently we don't erase them from the map. Done -- To view, visit http://gerrit.cloudera.org:8080/15185 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id611e1c683df2721fd058f753b8686a688a5990d Gerrit-Change-Number: 15185 Gerrit-PatchSet: 12 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Sat, 22 Feb 2020 02:01:34 +0000 Gerrit-HasComments: Yes
