Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15185 )
Change subject: [cpp] KUDU-2971: protobuf-based wrapper for subprocesses ...................................................................... Patch Set 12: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/15185/12/src/kudu/subprocess/server.cc File src/kudu/subprocess/server.cc: http://gerrit.cloudera.org:8080/#/c/15185/12/src/kudu/subprocess/server.cc@237 PS12, Line 237: while (!closing_.load()) { Another thing you can do is convert this into a CountDownLatch. That way you won't have to wait the full subprocess_deadline_checking_interval_ms for the deadline thread to exit when it's time to shut down, because you can combine the sleep and the "are we closed?" check into one operation on the latch. Fine to do that in a follow-up if you prefer. -- To view, visit http://gerrit.cloudera.org:8080/15185 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id611e1c683df2721fd058f753b8686a688a5990d Gerrit-Change-Number: 15185 Gerrit-PatchSet: 12 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Sat, 22 Feb 2020 02:20:36 +0000 Gerrit-HasComments: Yes
