Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15274 )
Change subject: [clock] relax version constraint for NTP response ...................................................................... Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/15274/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15274/1//COMMIT_MSG@13 PS1, Line 13: interestingly enough, the dedicated NTP servers of : other EC2 t2.large instances in my test cluster behaved as expected I'd expect the NTP server behavior to be a function of the NTP server software running in the instance. Was there a difference in the r5ad.xlarge and t2.large instances you tested with? http://gerrit.cloudera.org:8080/#/c/15274/1//COMMIT_MSG@17 PS1, Line 17: Secion Section http://gerrit.cloudera.org:8080/#/c/15274/1//COMMIT_MSG@20 PS1, Line 20: the of the http://gerrit.cloudera.org:8080/#/c/15274/1//COMMIT_MSG@29 PS1, Line 29: As a side note, : I also explored options to implement a test scenario using MiniChronyd, : but I found no way to configure chronyd to behave in a non-conforming : manner described above. Seems like it'd be good to have the ability to create a "mock" chronyd that we can use to send arbitrary packets to the built-in NTP client. Or, alternatively, an interceptor that can sit between a real chronyd and the built-in NTP client, and modify packets to contrive test scenarios. My only issue with this patch is that it has no regression test coverage; if someone accidentally reverts your patch down the line, we won't notice. Is there a minimal amount of "mocking" we could use to test this scenario that won't take a long time to implement? http://gerrit.cloudera.org:8080/#/c/15274/1/src/kudu/clock/builtin_ntp.cc File src/kudu/clock/builtin_ntp.cc: http://gerrit.cloudera.org:8080/#/c/15274/1/src/kudu/clock/builtin_ntp.cc@732 PS1, Line 732: Secion Section -- To view, visit http://gerrit.cloudera.org:8080/15274 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1df3549616bbced696380458978c33264ed636c9 Gerrit-Change-Number: 15274 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Sun, 23 Feb 2020 22:10:27 +0000 Gerrit-HasComments: Yes
