Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/15307 )
Change subject: [tserver] fix error code for DeleteTablet requests ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/15307/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15307/1//COMMIT_MSG@13 PS1, Line 13: If not do this, the tablet will not be deleted by tserver : until next time tserver send full tablet report to the leader master. > Why is this a problem? The tserver will include the newly copied tablet in The reason is that when tserver reports the newly copied tablet to master, the tablet might still be in copying state and can't be deleted. Since the tablet report has been sent to master, this replica might not be deleted forever. See the codes in https://github.com/apache/kudu/blob/01b667407f0f36732c67451825ea6e0434b191de/src/kudu/tserver/ts_tablet_manager.cc#L1144 , I think when replica starts, it will be marked dirty and it's tablet report could be sent to the master, then master responds by sending a new delete request. But at this point the passed TransitionInProgressDeleter object in OpenTablet method might not be destructed. I'm not sure if my understanding is correct, but we did find some tablets can't be deleted normally in a big cluster. -- To view, visit http://gerrit.cloudera.org:8080/15307 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I591dc8daceb81f9e800098be77c928d391cdc00a Gerrit-Change-Number: 15307 Gerrit-PatchSet: 1 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Comment-Date: Fri, 28 Feb 2020 10:47:53 +0000 Gerrit-HasComments: Yes
