Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15307 )
Change subject: [tserver] fix error code for DeleteTablet requests ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/15307/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15307/1//COMMIT_MSG@13 PS1, Line 13: If not do this, the tablet will not be deleted by tserver : until next time tserver send full tablet report to the leader master. > I think let the master retry to send DeleteTablet request is acceptable. I disagree; it erodes the wonderful work you did in commit 23e07e3a9 which reduced the amount of unnecessary task RPC traffic between the masters and tservers. > But maybe it's difficult to explicitly destroy the > TransitionInProgressDeleter because sometimes OpenTablet is asynchronous. I see that TransitionInProgressDeleter uses shared ownership. Could we give it exclusive ownership semantics and "move" it into asynchronous OpenTablet functors? Then it's only the responsibility of OpenTablet to destroy it and call MarkDirty. -- To view, visit http://gerrit.cloudera.org:8080/15307 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I591dc8daceb81f9e800098be77c928d391cdc00a Gerrit-Change-Number: 15307 Gerrit-PatchSet: 7 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Comment-Date: Tue, 03 Mar 2020 06:39:38 +0000 Gerrit-HasComments: Yes
